From 0e0d1a5f11f87aaa8830afb085fde05c8a3a8949 Mon Sep 17 00:00:00 2001
From: shancds <shancds1@gmail.com>
Date: Tue, 17 Jun 2025 16:46:36 +0530
Subject: [PATCH] refactor(project-view-board): clean up code and improve task
 handling logic

- Removed unnecessary conditional checks and whitespace for better readability.
- Streamlined task movement logic to enhance performance during drag-and-drop operations.
- Improved socket event emission for task sort order changes, ensuring more reliable updates.
- Cleaned up comments and organized code structure for clarity.
---
 .../projects/projectView/board/project-view-board.tsx     | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/worklenz-frontend/src/pages/projects/projectView/board/project-view-board.tsx b/worklenz-frontend/src/pages/projects/projectView/board/project-view-board.tsx
index b829aacb..3f886223 100644
--- a/worklenz-frontend/src/pages/projects/projectView/board/project-view-board.tsx
+++ b/worklenz-frontend/src/pages/projects/projectView/board/project-view-board.tsx
@@ -245,7 +245,6 @@ const ProjectViewBoard = () => {
       if (
         activeGroupId &&
         overGroupId &&
-        activeGroupId !== overGroupId &&
         active.data.current?.type === 'task'
       ) {
         // Find the target index in the over group
@@ -260,7 +259,6 @@ const ProjectViewBoard = () => {
             targetIndex = targetGroup.tasks.length;
           }
         }
-
         // Use debounced move task to prevent rapid updates
         debouncedMoveTask(
           activeId as string,
@@ -342,7 +340,6 @@ const ProjectViewBoard = () => {
 
       // Find indices
       let fromIndex = sourceGroup.tasks.findIndex(t => t.id === task.id);
-
       // Handle case where task is not found in source group (might have been moved already in UI)
       if (fromIndex === -1) {
         logger.info('Task not found in source group. Using task sort_order from task object.');
@@ -379,7 +376,7 @@ const ProjectViewBoard = () => {
         };
 
         // logger.error('Emitting socket event with payload (task not found in source):', body);
-
+        
         // Emit socket event
         if (socket) {
           socket.emit(SocketEvents.TASK_SORT_ORDER_CHANGE.toString(), body);
@@ -416,7 +413,6 @@ const ProjectViewBoard = () => {
       const toPos = targetGroup.tasks[toIndex]?.sort_order ||
         targetGroup.tasks[targetGroup.tasks.length - 1]?.sort_order ||
         -1;
-
       // Prepare socket event payload
       const body = {
         project_id: projectId,
@@ -429,7 +425,6 @@ const ProjectViewBoard = () => {
         task,
         team_id: currentSession?.team_id
       };
-
       // Emit socket event
       if (socket) {
         socket.emit(SocketEvents.TASK_SORT_ORDER_CHANGE.toString(), body);
@@ -443,7 +438,6 @@ const ProjectViewBoard = () => {
           }
         });
       }
-
       // Track analytics event
       trackMixpanelEvent(evt_project_task_list_drag_and_move);
     }