From 1969fbd1dc11389fdccdd53d71225b9b14676eee Mon Sep 17 00:00:00 2001
From: shancds <shancds1@gmail.com>
Date: Mon, 26 May 2025 10:18:49 +0530
Subject: [PATCH] feat(ratecard-drawer): enhance rate card deletion logic and
 button disable condition feat(ratecard-settings): update useEffect
 dependencies for fetching rate cards

---
 .../src/features/finance/ratecard-drawer/ratecard-drawer.tsx  | 4 ++--
 .../src/pages/settings/ratecard/ratecard-settings.tsx         | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/worklenz-frontend/src/features/finance/ratecard-drawer/ratecard-drawer.tsx b/worklenz-frontend/src/features/finance/ratecard-drawer/ratecard-drawer.tsx
index e39ca10d..70db6293 100644
--- a/worklenz-frontend/src/features/finance/ratecard-drawer/ratecard-drawer.tsx
+++ b/worklenz-frontend/src/features/finance/ratecard-drawer/ratecard-drawer.tsx
@@ -292,7 +292,7 @@ const RatecardDrawer = ({
     if (
       drawerRatecard &&
       (drawerRatecard.jobRolesList?.length === 0 || !drawerRatecard.jobRolesList) &&
-      name === 'Untitled Rate Card'
+      (name === 'Untitled Rate Card' || name === '' || name === undefined)
     ) {
       await dispatch(deleteRateCard(drawerRatecard.id as string));
     }
@@ -344,7 +344,7 @@ const RatecardDrawer = ({
       width={700}
       footer={
         <Flex justify="end" gap={16} style={{ marginTop: 16 }}>
-          <Button style={{ marginBottom: 24 }} onClick={handleSave} type="primary">{t('saveButton')}</Button>
+          <Button style={{ marginBottom: 24 }} onClick={handleSave} type="primary" disabled={name === '' || name === 'Untitled Rate Card' && roles.length ===0}>{t('saveButton')}</Button>
         </Flex>
       }
     >
diff --git a/worklenz-frontend/src/pages/settings/ratecard/ratecard-settings.tsx b/worklenz-frontend/src/pages/settings/ratecard/ratecard-settings.tsx
index 4e149e84..d236e91a 100644
--- a/worklenz-frontend/src/pages/settings/ratecard/ratecard-settings.tsx
+++ b/worklenz-frontend/src/pages/settings/ratecard/ratecard-settings.tsx
@@ -87,7 +87,7 @@ const RatecardSettings: React.FC = () => {
 
   useEffect(() => {
     fetchRateCards();
-  }, [toggleRatecardDrawer]);
+  }, [toggleRatecardDrawer, dispatch]);