bo/worklenz
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(labels-controller): update color validation to use WorklenzColorShades for label updates

Browse Source 
- Modified color validation logic in `updateLabel` method to check against `WorklenzColorShades` instead of `WorklenzColorCodes`.
- Ensured that the color input is validated correctly during label updates, enhancing data integrity.
This commit is contained in:
Chamika J
2025-08-04 15:28:31 +05:30
parent 6e37208f62
commit 210a9a7aba
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
worklenz-backend/src/controllers/labels-controller.ts
View File

@@ -5,7 +5,7 @@ import db from "../config/db";
import {ServerResponse} from "../models/server-response"; import {ServerResponse} from "../models/server-response";
import WorklenzControllerBase from "./worklenz-controller-base"; import WorklenzControllerBase from "./worklenz-controller-base";
import HandleExceptions from "../decorators/handle-exceptions"; import HandleExceptions from "../decorators/handle-exceptions";
import {TASK_PRIORITY_COLOR_ALPHA, WorklenzColorCodes} from "../shared/constants"; import {TASK_PRIORITY_COLOR_ALPHA, WorklenzColorCodes, WorklenzColorShades} from "../shared/constants";
export default class LabelsController extends WorklenzControllerBase { export default class LabelsController extends WorklenzControllerBase {
@HandleExceptions() @HandleExceptions()
@@ -73,7 +73,7 @@ export default class LabelsController extends WorklenzControllerBase {
WHERE id = $1 WHERE id = $1
AND team_id = $2;`; AND team_id = $2;`;
if (!WorklenzColorCodes.includes(req.body.color)) if (!Object.values(WorklenzColorShades).flat().includes(req.body.color))
return res.status(400).send(new ServerResponse(false, null)); return res.status(400).send(new ServerResponse(false, null));
const result = await db.query(q, [req.params.id, req.user?.team_id, req.body.color]); const result = await db.query(q, [req.params.id, req.user?.team_id, req.body.color]);
@@ -92,7 +92,7 @@ export default class LabelsController extends WorklenzControllerBase {
} }
if (req.body.color) { if (req.body.color) {
if (!WorklenzColorCodes.includes(req.body.color)) if (!Object.values(WorklenzColorShades).flat().includes(req.body.color))
return res.status(400).send(new ServerResponse(false, null)); return res.status(400).send(new ServerResponse(false, null));
updates.push(`color_code = $${paramIndex++}`); updates.push(`color_code = $${paramIndex++}`);
values.push(req.body.color); values.push(req.body.color);