bo/worklenz
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(performance): implement extensive performance optimizations across task management components

Browse Source 
- Introduced batching and optimized query handling in SQL functions for improved performance during large updates.
- Enhanced task sorting functions with batching to reduce load times and improve responsiveness.
- Implemented performance monitoring utilities to track render times, memory usage, and long tasks, providing insights for further optimizations.
- Added performance analysis component to visualize metrics and identify bottlenecks in task management.
- Optimized drag-and-drop functionality with CSS enhancements to ensure smooth interactions and reduce layout thrashing.
- Refined task row rendering logic to minimize DOM updates and improve loading behavior for large lists.
- Introduced aggressive virtualization and memoization strategies to enhance rendering performance in task lists.
This commit is contained in:
chamiakJ
2025-06-30 07:48:32 +05:30
parent e3324f0707
commit 7fdea2a285
11 changed files with 2003 additions and 457 deletions
Download Patch File Download Diff File Expand all files Collapse all files

149
worklenz-frontend/src/components/task-management/drag-drop-optimized.css Normal file
View File

@@ -0,0 +1,149 @@
/* DRAG AND DROP PERFORMANCE OPTIMIZATIONS */
/* Force GPU acceleration for all drag operations */
[data-dnd-draggable],
[data-dnd-drag-handle],
[data-dnd-overlay] {
transform: translateZ(0);
will-change: transform;
backface-visibility: hidden;
perspective: 1000px;
}
/* Optimize drag handle for instant response */
.drag-handle-optimized {
cursor: grab;
user-select: none;
touch-action: none;
-webkit-user-select: none;
-webkit-touch-callout: none;
-webkit-tap-highlight-color: transparent;
}
.drag-handle-optimized:active {
cursor: grabbing;
}
/* Disable all transitions during drag for instant response */
[data-dnd-dragging="true"] *,
[data-dnd-dragging="true"] {
transition: none !important;
animation: none !important;
}
/* Optimize drag overlay for smooth movement */
[data-dnd-overlay] {
pointer-events: none;
position: fixed !important;
z-index: 9999;
transform: translateZ(0);
will-change: transform;
backface-visibility: hidden;
}
/* Reduce layout thrashing during drag */
.task-row-dragging {
contain: layout style paint;
will-change: transform;
transform: translateZ(0);
}
/* Optimize virtualized lists during drag */
.react-window-list {
contain: layout style;
will-change: scroll-position;
}
.react-window-list-item {
contain: layout style;
will-change: transform;
}
/* Disable hover effects during drag */
[data-dnd-dragging="true"] .task-row:hover {
background-color: inherit !important;
}
/* Optimize cursor changes */
.task-row {
cursor: default;
}
.task-row[data-dnd-dragging="true"] {
cursor: grabbing;
}
/* Performance optimizations for large lists */
.virtualized-task-container {
contain: layout style paint;
will-change: scroll-position;
transform: translateZ(0);
}
/* Reduce repaints during scroll */
.task-groups-container {
contain: layout style;
will-change: scroll-position;
}
/* Optimize sortable context */
[data-dnd-sortable-context] {
contain: layout style;
}
/* Disable animations during drag operations */
[data-dnd-context] [data-dnd-dragging="true"] * {
transition: none !important;
animation: none !important;
}
/* Optimize drop indicators */
.drop-indicator {
contain: layout style;
will-change: opacity;
transition: opacity 0.1s ease;
}
/* Performance optimizations for touch devices */
@media (pointer: coarse) {
.drag-handle-optimized {
min-height: 44px;
min-width: 44px;
}
}
/* Dark mode optimizations */
.dark [data-dnd-dragging="true"],
[data-theme="dark"] [data-dnd-dragging="true"] {
background-color: rgba(255, 255, 255, 0.05) !important;
}
/* Reduce memory usage during drag */
[data-dnd-dragging="true"] img,
[data-dnd-dragging="true"] svg {
contain: layout style paint;
}
/* Optimize for high DPI displays */
@media (-webkit-min-device-pixel-ratio: 2), (min-resolution: 192dpi) {
[data-dnd-overlay] {
transform: translateZ(0) scale(1);
}
}
/* Disable text selection during drag */
[data-dnd-dragging="true"] {
-webkit-user-select: none;
-moz-user-select: none;
-ms-user-select: none;
user-select: none;
}
/* Optimize for reduced motion preferences */
@media (prefers-reduced-motion: reduce) {
[data-dnd-overlay],
[data-dnd-dragging="true"] {
transition: none !important;
animation: none !important;
}
}

284
worklenz-frontend/src/components/task-management/performance-analysis.tsx Normal file
View File

@@ -0,0 +1,284 @@
import React, { useState, useEffect, useCallback } from 'react';
import { Card, Button, Table, Progress, Alert, Space, Typography, Divider } from 'antd';
import { performanceMonitor } from '@/utils/performance-monitor';
const { Title, Text } = Typography;
interface PerformanceAnalysisProps {
projectId: string;
}
const PerformanceAnalysis: React.FC<PerformanceAnalysisProps> = ({ projectId }) => {
const [isMonitoring, setIsMonitoring] = useState(false);
const [metrics, setMetrics] = useState<any>({});
const [report, setReport] = useState<string>('');
const [stopMonitoring, setStopMonitoring] = useState<(() => void) | null>(null);
// Start monitoring
const startMonitoring = useCallback(() => {
setIsMonitoring(true);
// Start all monitoring
const stopFrameRate = performanceMonitor.startFrameRateMonitoring();
const stopLongTasks = performanceMonitor.startLongTaskMonitoring();
const stopLayoutThrashing = performanceMonitor.startLayoutThrashingMonitoring();
// Set up periodic memory monitoring
const memoryInterval = setInterval(() => {
performanceMonitor.monitorMemory();
}, 1000);
// Set up periodic metrics update
const metricsInterval = setInterval(() => {
setMetrics(performanceMonitor.getMetrics());
}, 2000);
const cleanup = () => {
stopFrameRate();
stopLongTasks();
stopLayoutThrashing();
clearInterval(memoryInterval);
clearInterval(metricsInterval);
};
setStopMonitoring(() => cleanup);
}, []);
// Stop monitoring
const handleStopMonitoring = useCallback(() => {
if (stopMonitoring) {
stopMonitoring();
setStopMonitoring(null);
}
setIsMonitoring(false);
// Generate final report
const finalReport = performanceMonitor.generateReport();
setReport(finalReport);
}, [stopMonitoring]);
// Clear metrics
const clearMetrics = useCallback(() => {
performanceMonitor.clear();
setMetrics({});
setReport('');
}, []);
// Download report
const downloadReport = useCallback(() => {
if (report) {
const blob = new Blob([report], { type: 'application/json' });
const url = URL.createObjectURL(blob);
const a = document.createElement('a');
a.href = url;
a.download = `performance-report-${projectId}-${new Date().toISOString()}.json`;
document.body.appendChild(a);
a.click();
document.body.removeChild(a);
URL.revokeObjectURL(url);
}
}, [report, projectId]);
// Cleanup on unmount
useEffect(() => {
return () => {
if (stopMonitoring) {
stopMonitoring();
}
};
}, [stopMonitoring]);
// Prepare table data
const tableData = Object.entries(metrics).map(([key, value]: [string, any]) => ({
key,
metric: key,
average: value.average.toFixed(2),
count: value.count,
min: value.min.toFixed(2),
max: value.max.toFixed(2),
status: getMetricStatus(key, value.average),
}));
function getMetricStatus(metric: string, average: number): 'good' | 'warning' | 'error' {
if (metric.includes('render-time')) {
return average > 16 ? 'error' : average > 8 ? 'warning' : 'good';
}
if (metric === 'fps') {
return average < 30 ? 'error' : average < 55 ? 'warning' : 'good';
}
if (metric.includes('memory-used') && metric.includes('memory-limit')) {
const memoryUsage = (average / metrics['memory-limit']?.average) * 100;
return memoryUsage > 80 ? 'error' : memoryUsage > 50 ? 'warning' : 'good';
}
return 'good';
}
const columns = [
{
title: 'Metric',
dataIndex: 'metric',
key: 'metric',
render: (text: string) => (
<Text code style={{ fontSize: '12px' }}>
{text}
</Text>
),
},
{
title: 'Average',
dataIndex: 'average',
key: 'average',
render: (text: string, record: any) => {
const color = record.status === 'error' ? '#ff4d4f' :
record.status === 'warning' ? '#faad14' : '#52c41a';
return <Text style={{ color, fontWeight: 500 }}>{text}</Text>;
},
},
{
title: 'Count',
dataIndex: 'count',
key: 'count',
},
{
title: 'Min',
dataIndex: 'min',
key: 'min',
},
{
title: 'Max',
dataIndex: 'max',
key: 'max',
},
{
title: 'Status',
dataIndex: 'status',
key: 'status',
render: (status: string) => {
const color = status === 'error' ? '#ff4d4f' :
status === 'warning' ? '#faad14' : '#52c41a';
const text = status === 'error' ? 'Poor' :
status === 'warning' ? 'Fair' : 'Good';
return <Text style={{ color, fontWeight: 500 }}>{text}</Text>;
},
},
];
return (
<Card
title="Performance Analysis"
style={{ marginBottom: 16 }}
extra={
<Space>
{!isMonitoring ? (
<Button type="primary" onClick={startMonitoring}>
Start Monitoring
</Button>
) : (
<Button danger onClick={handleStopMonitoring}>
Stop Monitoring
</Button>
)}
<Button onClick={clearMetrics}>Clear</Button>
{report && (
<Button onClick={downloadReport}>Download Report</Button>
)}
</Space>
}
>
{isMonitoring && (
<Alert
message="Performance monitoring is active"
description="Collecting metrics for component renders, Redux operations, memory usage, and frame rate."
type="info"
showIcon
style={{ marginBottom: 16 }}
/>
)}
{Object.keys(metrics).length > 0 && (
<>
<Title level={5}>Performance Metrics</Title>
<Table
dataSource={tableData}
columns={columns}
pagination={false}
size="small"
style={{ marginBottom: 16 }}
/>
<Divider />
<Title level={5}>Key Performance Indicators</Title>
<div style={{ display: 'grid', gridTemplateColumns: 'repeat(auto-fit, minmax(200px, 1fr))', gap: 16 }}>
{metrics.fps && (
<Card size="small">
<Text>Frame Rate</Text>
<div style={{ fontSize: '24px', fontWeight: 'bold', color: getMetricStatus('fps', metrics.fps.average) === 'error' ? '#ff4d4f' : '#52c41a' }}>
{metrics.fps.average.toFixed(1)} FPS
</div>
<Progress
percent={Math.min((metrics.fps.average / 60) * 100, 100)}
size="small"
status={getMetricStatus('fps', metrics.fps.average) === 'error' ? 'exception' : 'active'}
/>
</Card>
)}
{metrics['memory-used'] && metrics['memory-limit'] && (
<Card size="small">
<Text>Memory Usage</Text>
<div style={{ fontSize: '24px', fontWeight: 'bold' }}>
{((metrics['memory-used'].average / metrics['memory-limit'].average) * 100).toFixed(1)}%
</div>
<Progress
percent={(metrics['memory-used'].average / metrics['memory-limit'].average) * 100}
size="small"
status={(metrics['memory-used'].average / metrics['memory-limit'].average) * 100 > 80 ? 'exception' : 'active'}
/>
</Card>
)}
{metrics['layout-thrashing-count'] && (
<Card size="small">
<Text>Layout Thrashing</Text>
<div style={{ fontSize: '24px', fontWeight: 'bold', color: metrics['layout-thrashing-count'].count > 10 ? '#ff4d4f' : '#52c41a' }}>
{metrics['layout-thrashing-count'].count}
</div>
<Text type="secondary">Detected instances</Text>
</Card>
)}
{metrics['long-task-duration'] && (
<Card size="small">
<Text>Long Tasks</Text>
<div style={{ fontSize: '24px', fontWeight: 'bold', color: metrics['long-task-duration'].count > 0 ? '#ff4d4f' : '#52c41a' }}>
{metrics['long-task-duration'].count}
</div>
<Text type="secondary">Tasks &gt; 50ms</Text>
</Card>
)}
</div>
</>
)}
{report && (
<>
<Divider />
<Title level={5}>Performance Report</Title>
<pre style={{
backgroundColor: '#f5f5f5',
padding: 16,
borderRadius: 4,
fontSize: '12px',
maxHeight: '300px',
overflow: 'auto'
}}>
{report}
</pre>
</>
)}
</Card>
);
};
export default PerformanceAnalysis;

169
worklenz-frontend/src/components/task-management/task-list-board.tsx
View File

@@ -44,9 +44,15 @@ import TaskRow from './task-row';
import VirtualizedTaskList from './virtualized-task-list';
import { AppDispatch } from '@/app/store';
import { shallowEqual } from 'react-redux';
import { performanceMonitor } from '@/utils/performance-monitor';
import debugPerformance from '@/utils/debug-performance';
// Import the improved TaskListFilters component synchronously to avoid suspense
import ImprovedTaskFilters from './improved-task-filters';
import PerformanceAnalysis from './performance-analysis';
// Import drag and drop performance optimizations
import './drag-drop-optimized.css';
interface TaskListBoardProps {
projectId: string;
@@ -111,12 +117,21 @@ const TaskListBoard: React.FC<TaskListBoardProps> = ({ projectId, className = ''
// Get theme from Redux store
const isDarkMode = useSelector((state: RootState) => state.themeReducer?.mode === 'dark');
const themeClass = isDarkMode ? 'dark' : 'light';
// Build a tasksById map for efficient lookup
const tasksById = useMemo(() => {
const map: Record<string, Task> = {};
tasks.forEach(task => { map[task.id] = task; });
return map;
}, [tasks]);
// Drag and Drop sensors - optimized for better performance
const sensors = useSensors(
useSensor(PointerSensor, {
activationConstraint: {
distance: 3, // Reduced from 8 for more responsive dragging
distance: 0, // No distance requirement for immediate response
delay: 0, // No delay for immediate activation
},
}),
useSensor(KeyboardSensor, {
@@ -129,8 +144,47 @@ const TaskListBoard: React.FC<TaskListBoardProps> = ({ projectId, className = ''
if (projectId && !hasInitialized.current) {
hasInitialized.current = true;
// Fetch real tasks from V3 API (minimal processing needed)
dispatch(fetchTasksV3(projectId));
// Start performance monitoring
if (process.env.NODE_ENV === 'development') {
const stopPerformanceCheck = debugPerformance.runPerformanceCheck();
// Monitor task loading performance
const startTime = performance.now();
// Monitor API call specifically
const apiStartTime = performance.now();
// Fetch real tasks from V3 API (minimal processing needed)
dispatch(fetchTasksV3(projectId)).then((result: any) => {
const apiTime = performance.now() - apiStartTime;
const totalLoadTime = performance.now() - startTime;
console.log(`API call took: ${apiTime.toFixed(2)}ms`);
console.log(`Total task loading took: ${totalLoadTime.toFixed(2)}ms`);
console.log(`Tasks loaded: ${result.payload?.tasks?.length || 0}`);
console.log(`Groups created: ${result.payload?.groups?.length || 0}`);
if (apiTime > 5000) {
console.error(`🚨 API call is extremely slow: ${apiTime.toFixed(2)}ms - Check backend performance`);
}
if (totalLoadTime > 1000) {
console.warn(`🚨 Slow task loading detected: ${totalLoadTime.toFixed(2)}ms`);
}
// Log performance metrics after loading
debugPerformance.logMemoryUsage();
debugPerformance.logDOMNodes();
return stopPerformanceCheck;
}).catch((error) => {
console.error('Task loading failed:', error);
return stopPerformanceCheck;
});
} else {
// Fetch real tasks from V3 API (minimal processing needed)
dispatch(fetchTasksV3(projectId));
}
}
}, [projectId, dispatch]);
@@ -177,54 +231,55 @@ const TaskListBoard: React.FC<TaskListBoardProps> = ({ projectId, className = ''
[tasks, currentGrouping]
);
// Throttled drag over handler for better performance
const handleDragOver = useCallback(
throttle((event: DragOverEvent) => {
const { active, over } = event;
// Immediate drag over handler for instant response
const handleDragOver = useCallback((event: DragOverEvent) => {
const { active, over } = event;
if (!over || !dragState.activeTask) return;
if (!over || !dragState.activeTask) return;
const activeTaskId = active.id as string;
const overContainer = over.id as string;
const activeTaskId = active.id as string;
const overContainer = over.id as string;
// Clear any existing timeout
if (dragOverTimeoutRef.current) {
clearTimeout(dragOverTimeoutRef.current);
// Clear any existing timeout
if (dragOverTimeoutRef.current) {
clearTimeout(dragOverTimeoutRef.current);
}
// PERFORMANCE OPTIMIZATION: Immediate response for instant UX
// Only update if we're hovering over a different container
const targetTask = tasks.find(t => t.id === overContainer);
let targetGroupId = overContainer;
if (targetTask) {
// PERFORMANCE OPTIMIZATION: Use switch instead of multiple if statements
switch (currentGrouping) {
case 'status':
targetGroupId = `status-${targetTask.status}`;
break;
case 'priority':
targetGroupId = `priority-${targetTask.priority}`;
break;
case 'phase':
targetGroupId = `phase-${targetTask.phase}`;
break;
}
}
// Optimistic update with throttling
dragOverTimeoutRef.current = setTimeout(() => {
// Only update if we're hovering over a different container
const targetTask = tasks.find(t => t.id === overContainer);
let targetGroupId = overContainer;
if (targetTask) {
if (currentGrouping === 'status') {
targetGroupId = `status-${targetTask.status}`;
} else if (currentGrouping === 'priority') {
targetGroupId = `priority-${targetTask.priority}`;
} else if (currentGrouping === 'phase') {
targetGroupId = `phase-${targetTask.phase}`;
}
}
if (targetGroupId !== dragState.activeGroupId) {
// Perform optimistic update for visual feedback
const targetGroup = taskGroups.find(g => g.id === targetGroupId);
if (targetGroup) {
dispatch(
optimisticTaskMove({
taskId: activeTaskId,
newGroupId: targetGroupId,
newIndex: targetGroup.taskIds.length,
})
);
}
}
}, 50); // 50ms throttle for drag over events
}, 50),
[dragState, tasks, taskGroups, currentGrouping, dispatch]
);
if (targetGroupId !== dragState.activeGroupId) {
// PERFORMANCE OPTIMIZATION: Use findIndex for better performance
const targetGroupIndex = taskGroups.findIndex(g => g.id === targetGroupId);
if (targetGroupIndex !== -1) {
const targetGroup = taskGroups[targetGroupIndex];
dispatch(
optimisticTaskMove({
taskId: activeTaskId,
newGroupId: targetGroupId,
newIndex: targetGroup.taskIds.length,
})
);
}
}
}, [dragState, tasks, taskGroups, currentGrouping, dispatch]);
const handleDragEnd = useCallback(
(event: DragEndEvent) => {
@@ -375,7 +430,7 @@ const TaskListBoard: React.FC<TaskListBoardProps> = ({ projectId, className = ''
}
return (
<div className={`task-list-board ${className}`} ref={containerRef}>
<div className={`task-list-board ${className} ${themeClass}`} ref={containerRef}>
<DndContext
sensors={sensors}
collisionDetection={closestCorners}
@@ -392,6 +447,11 @@ const TaskListBoard: React.FC<TaskListBoardProps> = ({ projectId, className = ''
<ImprovedTaskFilters position="list" />
</div>
{/* Performance Analysis - Only show in development */}
{process.env.NODE_ENV === 'development' && (
<PerformanceAnalysis projectId={projectId} />
)}
{/* Virtualized Task Groups Container */}
<div className="task-groups-container">
{loading ? (
@@ -419,21 +479,22 @@ const TaskListBoard: React.FC<TaskListBoardProps> = ({ projectId, className = ''
) : (
<div className="virtualized-task-groups">
{taskGroups.map((group, index) => {
// PERFORMANCE OPTIMIZATION: Optimized height calculations
// PERFORMANCE OPTIMIZATION: Pre-calculate height values to avoid recalculation
const groupTasks = group.taskIds.length;
const baseHeight = 120; // Header + column headers + add task row
const taskRowsHeight = groupTasks * 40; // 40px per task row
// PERFORMANCE OPTIMIZATION: Dynamic height based on task count and virtualization
const shouldVirtualizeGroup = groupTasks > 20;
const minGroupHeight = shouldVirtualizeGroup ? 200 : 150; // Smaller minimum for non-virtualized
const maxGroupHeight = shouldVirtualizeGroup ? 800 : 400; // Different max based on virtualization
// PERFORMANCE OPTIMIZATION: Simplified height calculation
const shouldVirtualizeGroup = groupTasks > 15; // Reduced threshold
const minGroupHeight = shouldVirtualizeGroup ? 180 : 120; // Smaller minimum
const maxGroupHeight = shouldVirtualizeGroup ? 600 : 300; // Smaller maximum
const calculatedHeight = baseHeight + taskRowsHeight;
const groupHeight = Math.max(
minGroupHeight,
Math.min(calculatedHeight, maxGroupHeight)
);
// PERFORMANCE OPTIMIZATION: Memoize group rendering
return (
<VirtualizedTaskList
key={group.id}
@@ -447,6 +508,7 @@ const TaskListBoard: React.FC<TaskListBoardProps> = ({ projectId, className = ''
onToggleSubtasks={handleToggleSubtasks}
height={groupHeight}
width={1200}
tasksById={tasksById}
/>
);
})}
@@ -467,9 +529,6 @@ const TaskListBoard: React.FC<TaskListBoardProps> = ({ projectId, className = ''
<style>{`
.task-groups-container {
max-height: calc(100vh - 300px);
overflow-y: auto;
overflow-x: visible;
padding: 8px 8px 8px 0;
border-radius: 8px;
position: relative;

180
worklenz-frontend/src/components/task-management/task-row-optimized.css
View File

@@ -2,42 +2,56 @@
.task-row-optimized {
contain: layout style;
will-change: transform;
transform: translateZ(0); /* Force GPU acceleration */
/* Remove conflicting will-change and transform */
transition: background-color 0.15s ease-out, border-color 0.15s ease-out;
background: var(--task-bg-primary, #fff);
color: var(--task-text-primary, #262626);
border-color: var(--task-border-primary, #e8e8e8);
}
/* HOVER STATE FIX: Ensure hover states reset properly */
.task-row-optimized:not(:hover) {
/* Force reset of any stuck hover states */
contain: layout style;
/* SIMPLIFIED HOVER STATE: Remove complex containment and transforms */
.task-row-optimized:hover {
/* Remove transform that was causing GPU conflicts */
/* Remove complex containment rules */
}
.task-row-optimized:not(:hover) .task-open-button {
opacity: 0 !important;
visibility: hidden;
/* OPTIMIZED HOVER BUTTONS: Use opacity only, no visibility changes */
.task-open-button {
opacity: 0;
transition: opacity 0.15s ease-out;
/* Remove will-change to prevent GPU conflicts */
}
.task-row-optimized:not(:hover) .expand-icon-container.hover-only {
opacity: 0 !important;
visibility: hidden;
}
/* Force visibility on hover */
.task-row-optimized:hover .task-open-button {
visibility: visible;
opacity: 1;
}
/* OPTIMIZED EXPAND ICON: Simplified hover behavior */
.expand-icon-container.hover-only {
opacity: 0;
transition: opacity 0.15s ease-out;
}
.task-row-optimized:hover .expand-icon-container.hover-only {
visibility: visible;
opacity: 1;
}
.task-row-optimized:hover {
contain: layout style;
/* Don't use paint containment on hover as it can interfere with hover effects */
/* Force repaint to ensure hover states update properly */
transform: translateZ(0.001px);
/* REMOVE COMPLEX CONTAINMENT RULES that were causing layout thrashing */
.task-row-optimized:not(:hover) {
/* Remove forced containment and transforms */
}
.task-row-optimized:not(:hover) .task-open-button {
opacity: 0;
/* Remove !important and visibility changes */
}
.task-row-optimized:not(:hover) .expand-icon-container.hover-only {
opacity: 0;
/* Remove !important and visibility changes */
}
/* DRAG STATE: Simplified */
.task-row-optimized.task-row-dragging {
contain: layout;
will-change: transform;
@@ -61,23 +75,21 @@
.task-row-optimized.fully-loaded {
contain: layout style;
will-change: transform;
/* Remove will-change: transform to prevent conflicts */
}
/* REAL-TIME UPDATES: Prevent flickering during socket updates */
/* REAL-TIME UPDATES: Simplified stable content */
.task-row-optimized.stable-content {
contain: layout style;
will-change: transform;
/* Prevent content from disappearing during real-time updates */
/* Remove will-change to prevent GPU conflicts */
min-height: 40px;
/* Keep transitions for hover states but disable for layout changes */
transition: background-color 0.2s ease-in-out, border-color 0.2s ease-in-out;
/* Simplified transitions */
transition: background-color 0.15s ease-out, border-color 0.15s ease-out;
}
.task-row-optimized.stable-content * {
contain: layout;
will-change: auto;
/* Don't force opacity - let hover states work naturally */
/* Remove will-change to prevent conflicts */
}
/* Optimize initial render performance */
@@ -184,11 +196,14 @@
/* Dark mode optimizations */
.dark .task-row-optimized {
contain: layout style;
background: var(--task-bg-primary, #1f1f1f);
color: var(--task-text-primary, #fff);
border-color: var(--task-border-primary, #303030);
}
.dark .task-row-optimized:hover {
contain: layout style;
/* Don't use paint containment on hover as it can interfere with hover effects */
/* Remove complex containment rules */
}
/* Animation performance */
@@ -220,21 +235,20 @@
contain: strict;
}
/* PERFORMANCE OPTIMIZATION: GPU acceleration for better scrolling */
/* PERFORMANCE OPTIMIZATION: Simplified GPU acceleration */
.task-row-optimized {
backface-visibility: hidden;
-webkit-backface-visibility: hidden;
transform-style: preserve-3d;
-webkit-transform-style: preserve-3d;
/* Remove transform-style to prevent conflicts */
}
/* Optimize rendering layers */
.task-row-optimized.initial-load {
transform: translate3d(0, 0, 0);
/* Remove transform to prevent conflicts */
}
.task-row-optimized.fully-loaded {
transform: translate3d(0, 0, 0);
/* Remove transform to prevent conflicts */
}
/* Performance debugging */
@@ -282,29 +296,19 @@
box-sizing: border-box;
}
/* Task row hover effects for better performance */
/* SIMPLIFIED TASK ROW HOVER EFFECTS */
.task-cell-container:hover .task-open-button {
opacity: 1 !important;
opacity: 1;
}
.task-cell-container:not(:hover) .task-open-button {
opacity: 0 !important;
}
.task-open-button {
opacity: 0;
transition: opacity 0.2s ease-in-out;
/* Force hardware acceleration for smoother transitions */
transform: translateZ(0);
will-change: opacity;
}
/* Expand icon smart visibility */
/* Expand icon smart visibility - simplified */
.expand-icon-container {
transition: opacity 0.2s ease-in-out;
/* Force hardware acceleration for smoother transitions */
transform: translateZ(0);
will-change: opacity;
transition: opacity 0.15s ease-out;
/* Remove transform and will-change to prevent conflicts */
}
/* Always show expand icon if task has subtasks */
@@ -314,7 +318,7 @@
.expand-icon-container.has-subtasks .expand-toggle-btn {
opacity: 0.8;
transition: opacity 0.2s ease-in-out;
transition: opacity 0.15s ease-out;
}
.task-cell-container:hover .expand-icon-container.has-subtasks .expand-toggle-btn {
@@ -340,7 +344,7 @@
.expand-icon-container.hover-only .expand-toggle-btn {
opacity: 0.6;
transition: opacity 0.2s ease-in-out;
transition: opacity 0.15s ease-out;
}
.task-cell-container:hover .expand-icon-container.hover-only .expand-toggle-btn {
@@ -394,7 +398,7 @@
/* Task indicators hover effects */
.task-indicators .indicator-badge {
transition: all 0.2s ease-in-out;
transition: all 0.15s ease-out;
}
.task-indicators .indicator-badge:hover {
@@ -407,7 +411,7 @@
box-shadow: 0 2px 4px rgba(0, 0, 0, 0.3);
}
/* HOVER STATE DEBUGGING: Force hover state reset on mouse leave */
/* SIMPLIFIED HOVER STATE MANAGEMENT */
.task-row-optimized {
/* Ensure proper hover state management */
pointer-events: auto;
@@ -418,11 +422,71 @@
pointer-events: inherit;
}
/* Force browser to recalculate hover states */
/* Remove complex hover state forcing */
@supports (contain: layout) {
.task-row-optimized:not(:hover) {
contain: layout;
/* Force style recalculation */
animation: none;
/* Remove animation forcing */
}
}
.task-row-optimized.selected {
background: var(--task-selected-bg, #e6f7ff) !important;
border-left-color: var(--task-selected-border, #1890ff);
}
.task-row-optimized.drag-overlay {
background: var(--task-bg-primary, #fff);
color: var(--task-text-primary, #262626);
border: 1px solid var(--task-border-primary, #e8e8e8);
border-radius: 6px;
box-shadow: 0 6px 16px rgba(0,0,0,0.12);
z-index: 1000;
opacity: 0.95;
}
/* Dark mode support */
.dark .task-row-optimized.selected,
[data-theme="dark"] .task-row-optimized.selected {
background: var(--task-selected-bg, #1a2332) !important;
border-left-color: var(--task-selected-border, #1890ff);
}
.dark .task-row-optimized.drag-overlay,
[data-theme="dark"] .task-row-optimized.drag-overlay {
background: var(--task-bg-primary, #1f1f1f);
color: var(--task-text-primary, #fff);
border: 1px solid var(--task-border-primary, #303030);
box-shadow: 0 6px 16px rgba(0,0,0,0.32);
}
.task-row-optimized.is-dragging {
border: 3px solid #1890ff !important;
box-shadow: 0 0 24px 4px #1890ff, 0 6px 16px rgba(0,0,0,0.18);
opacity: 0.85 !important;
background: var(--task-bg-primary, #fff) !important;
z-index: 2000 !important;
transition: none !important;
}
.dark .task-row-optimized.is-dragging,
[data-theme="dark"] .task-row-optimized.is-dragging {
border: 3px solid #40a9ff !important;
box-shadow: 0 0 24px 4px #40a9ff, 0 6px 16px rgba(0,0,0,0.38);
background: var(--task-bg-primary, #1f1f1f) !important;
}
.task-row-optimized.drag-overlay {
border: 3px dashed #ff4d4f !important;
box-shadow: 0 0 32px 8px #ff4d4f, 0 6px 16px rgba(0,0,0,0.22);
background: #fffbe6 !important;
opacity: 0.95 !important;
z-index: 3000 !important;
}
.dark .task-row-optimized.drag-overlay,
[data-theme="dark"] .task-row-optimized.drag-overlay {
border: 3px dashed #ff7875 !important;
box-shadow: 0 0 32px 8px #ff7875, 0 6px 16px rgba(0,0,0,0.42);
background: #2a2a2a !important;
}

234
worklenz-frontend/src/components/task-management/task-row.tsx
View File

@@ -38,6 +38,7 @@ import {
import './task-row-optimized.css';
import { useAppDispatch } from '@/hooks/useAppDispatch';
import { setSelectedTaskId, setShowTaskDrawer, fetchTask } from '@/features/task-drawer/task-drawer.slice';
import useDragCursor from '@/hooks/useDragCursor';
interface TaskRowProps {
task: Task;
@@ -68,17 +69,22 @@ const STATUS_COLORS = {
done: '#52c41a',
} as const;
// Memoized sub-components for better performance
// Memoized sub-components for maximum performance
const DragHandle = React.memo<{ isDarkMode: boolean; attributes: any; listeners: any }>(({ isDarkMode, attributes, listeners }) => (
<Button
variant="text"
size="small"
icon={<HolderOutlined />}
className="opacity-40 hover:opacity-100 cursor-grab active:cursor-grabbing"
isDarkMode={isDarkMode}
<div
className="drag-handle-optimized flex items-center justify-center w-6 h-6 opacity-60 hover:opacity-100"
style={{
transition: 'opacity 0.1s ease', // Faster transition
}}
data-dnd-drag-handle="true"
{...attributes}
{...listeners}
/>
>
<HolderOutlined
className={`text-sm ${isDarkMode ? 'text-gray-400' : 'text-gray-500'}`}
style={{ pointerEvents: 'none' }} // Prevent icon from interfering
/>
</div>
));
const TaskKey = React.memo<{ taskKey: string; isDarkMode: boolean }>(({ taskKey, isDarkMode }) => (
@@ -178,12 +184,12 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
fixedColumns,
scrollableColumns,
}) => {
// PERFORMANCE OPTIMIZATION: Implement progressive loading
// Immediately load first few tasks to prevent blank content for visible items
const [isFullyLoaded, setIsFullyLoaded] = useState((index !== undefined && index < 10) || false);
// PERFORMANCE OPTIMIZATION: Aggressive progressive loading for large lists
// Only fully load first 5 tasks and tasks that are visible
const [isFullyLoaded, setIsFullyLoaded] = useState((index !== undefined && index < 5) || false);
const [isIntersecting, setIsIntersecting] = useState(false);
const rowRef = useRef<HTMLDivElement>(null);
const hasBeenFullyLoadedOnce = useRef((index !== undefined && index < 10) || false); // Track if we've ever been fully loaded
const hasBeenFullyLoadedOnce = useRef((index !== undefined && index < 5) || false); // Track if we've ever been fully loaded
// PERFORMANCE OPTIMIZATION: Only connect to socket after component is visible
const { socket, connected } = useSocket();
@@ -210,18 +216,14 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
const [entry] = entries;
if (entry.isIntersecting && !isIntersecting && !hasBeenFullyLoadedOnce.current) {
setIsIntersecting(true);
// Delay full loading slightly to prioritize visible content
const timeoutId = setTimeout(() => {
setIsFullyLoaded(true);
hasBeenFullyLoadedOnce.current = true; // Mark as fully loaded once
}, 50);
return () => clearTimeout(timeoutId);
// More aggressive loading - load immediately when visible
setIsFullyLoaded(true);
hasBeenFullyLoadedOnce.current = true; // Mark as fully loaded once
}
},
{
root: null,
rootMargin: '100px', // Start loading 100px before coming into view
rootMargin: '50px', // Reduced from 100px - load closer to viewport
threshold: 0.1,
}
);
@@ -237,6 +239,10 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
// Once fully loaded, always render full to prevent blanking during real-time updates
const shouldRenderFull = isFullyLoaded || hasBeenFullyLoadedOnce.current || isDragOverlay || editTaskName;
// PERFORMANCE OPTIMIZATION: Minimal initial render for non-visible tasks
// Only render essential columns during initial load to reduce DOM nodes
const shouldRenderMinimal = !shouldRenderFull && !isDragOverlay;
// REAL-TIME UPDATES: Ensure content stays loaded during socket updates
useEffect(() => {
if (shouldRenderFull && !hasBeenFullyLoadedOnce.current) {
@@ -244,7 +250,7 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
}
}, [shouldRenderFull]);
// Optimized drag and drop setup with better performance
// Optimized drag and drop setup with maximum performance
const {
attributes,
listeners,
@@ -260,8 +266,9 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
groupId,
},
disabled: isDragOverlay || !shouldRenderFull, // Disable drag until fully loaded
// Optimize animation performance
animateLayoutChanges: () => false, // Disable layout animations for better performance
// PERFORMANCE OPTIMIZATION: Disable all animations for maximum performance
animateLayoutChanges: () => false, // Disable layout animations
transition: null, // Disable transitions
});
// Get theme from Redux store - memoized selector
@@ -327,19 +334,19 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
setShowAddSubtask(false);
}, []);
// Optimized style calculations with better memoization
// Optimized style calculations with maximum performance
const dragStyle = useMemo(() => {
if (!isDragging && !transform) return {};
return {
transform: CSS.Transform.toString(transform),
transition,
transition: 'none', // Disable all transitions for instant response
opacity: isDragging ? 0.5 : 1,
zIndex: isDragging ? 1000 : 'auto',
// Add GPU acceleration for better performance
// PERFORMANCE OPTIMIZATION: Force GPU acceleration
willChange: isDragging ? 'transform' : 'auto',
};
}, [transform, transition, isDragging]);
}, [transform, isDragging]);
// Memoized event handlers with better dependency tracking
const handleSelectChange = useCallback((checked: boolean) => {
@@ -397,7 +404,7 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
// Optimized class name calculations with better memoization
const styleClasses = useMemo(() => {
const base = 'border-b transition-all duration-200'; // Reduced duration for better performance
const base = 'border-b transition-all duration-150'; // Reduced duration for better performance
const theme = isDarkMode
? 'border-gray-600 hover:bg-gray-800'
: 'border-gray-300 hover:bg-gray-50';
@@ -411,7 +418,7 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
return {
container: `${base} ${theme} ${background} ${selected} ${overlay}`,
taskName: `text-sm font-medium flex-1 overflow-hidden text-ellipsis whitespace-nowrap transition-colors duration-200 cursor-pointer ${
taskName: `text-sm font-medium flex-1 overflow-hidden text-ellipsis whitespace-nowrap transition-colors duration-150 cursor-pointer ${
isDarkMode ? 'text-gray-100 hover:text-blue-400' : 'text-gray-900 hover:text-blue-600'
} ${task.progress === 100 ? `line-through ${isDarkMode ? 'text-gray-400' : 'text-gray-500'}` : ''}`,
};
@@ -423,16 +430,14 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
assignee: createAssigneeAdapter(task),
}), [task]);
// PERFORMANCE OPTIMIZATION: Simplified column rendering for initial load
const renderColumnSimple = useCallback((col: { key: string; width: number }, isFixed: boolean, index: number, totalColumns: number) => {
// Fix border logic: if this is a fixed column, only consider it "last" if there are no scrollable columns
// If this is a scrollable column, use the normal logic
// PERFORMANCE OPTIMIZATION: Minimal column rendering for initial load
const renderMinimalColumn = useCallback((col: { key: string; width: number }, isFixed: boolean, index: number, totalColumns: number) => {
const isActuallyLast = isFixed
? (index === totalColumns - 1 && (!scrollableColumns || scrollableColumns.length === 0))
: (index === totalColumns - 1);
const borderClasses = `${isActuallyLast ? '' : 'border-r'} border-b ${isDarkMode ? 'border-gray-600' : 'border-gray-300'}`;
// Only render essential columns during initial load
// Only render essential columns during minimal load
switch (col.key) {
case 'drag':
return (
@@ -464,6 +469,8 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
<div key={col.key} className={`flex items-center px-2 ${borderClasses}`} style={{ width: col.width }}>
<div className="flex-1 min-w-0 flex flex-col justify-center h-full overflow-hidden">
<div className="flex items-center gap-2 h-5 overflow-hidden">
{/* Always reserve space for expand icon */}
<div style={{ width: 20, display: 'inline-block' }} />
<div className="flex-1 min-w-0">
<Typography.Text
ellipsis={{ tooltip: task.title }}
@@ -477,139 +484,21 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
</div>
);
case 'status':
return (
<div key={col.key} className={`flex items-center px-2 ${borderClasses}`} style={{ width: col.width }}>
<div className={`px-2 py-1 text-xs rounded ${isDarkMode ? 'bg-gray-700 text-gray-300' : 'bg-gray-100 text-gray-600'}`}>
{task.status === 'todo' ? 'To Do' :
task.status === 'doing' ? 'Doing' :
task.status === 'done' ? 'Done' :
task.status || 'To Do'}
</div>
</div>
);
case 'progress':
return (
<div key={col.key} className={`flex items-center justify-center px-2 ${borderClasses}`} style={{ width: col.width }}>
<div className={`text-xs ${isDarkMode ? 'text-gray-300' : 'text-gray-600'}`}>
{task.progress || 0}%
</div>
</div>
);
case 'priority':
return (
<div key={col.key} className={`flex items-center px-2 ${borderClasses}`} style={{ width: col.width }}>
<div className={`px-2 py-1 text-xs rounded ${isDarkMode ? 'bg-gray-700 text-gray-300' : 'bg-gray-100 text-gray-600'}`}>
{task.priority === 'critical' ? 'Critical' :
task.priority === 'high' ? 'High' :
task.priority === 'medium' ? 'Medium' :
task.priority === 'low' ? 'Low' :
task.priority || 'Medium'}
</div>
</div>
);
case 'phase':
return (
<div key={col.key} className={`flex items-center px-2 ${borderClasses}`} style={{ width: col.width }}>
<div className={`px-2 py-1 text-xs rounded ${isDarkMode ? 'bg-gray-700 text-gray-300' : 'bg-gray-100 text-gray-600'}`}>
{task.phase || 'No Phase'}
</div>
</div>
);
case 'members':
return (
<div key={col.key} className={`flex items-center px-2 ${borderClasses}`} style={{ width: col.width }}>
<div className="flex items-center gap-2">
{task.assignee_names && task.assignee_names.length > 0 ? (
<div className="flex items-center gap-1">
{task.assignee_names.slice(0, 3).map((member, index) => (
<div
key={index}
className={`w-6 h-6 rounded-full flex items-center justify-center text-xs font-medium ${
isDarkMode ? 'bg-gray-600 text-gray-200' : 'bg-gray-200 text-gray-700'
}`}
title={member.name}
>
{member.name ? member.name.charAt(0).toUpperCase() : '?'}
</div>
))}
{task.assignee_names.length > 3 && (
<div
className={`w-6 h-6 rounded-full flex items-center justify-center text-xs font-medium ${
isDarkMode ? 'bg-gray-600 text-gray-200' : 'bg-gray-200 text-gray-700'
}`}
>
+{task.assignee_names.length - 3}
</div>
)}
</div>
) : (
<div className={`w-6 h-6 rounded-full border-2 border-dashed flex items-center justify-center ${
isDarkMode ? 'border-gray-600' : 'border-gray-300'
}`}>
<UserOutlined className={`text-xs ${isDarkMode ? 'text-gray-600' : 'text-gray-400'}`} />
</div>
)}
</div>
</div>
);
case 'labels':
return (
<div key={col.key} className={`flex items-center px-2 ${borderClasses}`} style={{ width: col.width }}>
<div className="flex items-center gap-1 flex-wrap">
{task.labels && task.labels.length > 0 ? (
task.labels.slice(0, 3).map((label, index) => (
<div
key={index}
className={`px-2 py-1 text-xs rounded ${
isDarkMode ? 'bg-gray-700 text-gray-300' : 'bg-gray-100 text-gray-600'
}`}
style={{
backgroundColor: label.color || (isDarkMode ? '#374151' : '#f3f4f6'),
color: label.color ? '#ffffff' : undefined
}}
>
{label.name || 'Label'}
</div>
))
) : (
<div className={`px-2 py-1 text-xs rounded border-dashed border ${
isDarkMode ? 'border-gray-600 text-gray-600' : 'border-gray-300 text-gray-400'
}`}>
No labels
</div>
)}
{task.labels && task.labels.length > 3 && (
<div className={`px-2 py-1 text-xs rounded ${
isDarkMode ? 'bg-gray-700 text-gray-300' : 'bg-gray-100 text-gray-600'
}`}>
+{task.labels.length - 3}
</div>
)}
</div>
</div>
);
default:
// For non-essential columns, show placeholder during initial load
// For non-essential columns, show minimal placeholder
return (
<div key={col.key} className={`flex items-center px-2 ${borderClasses}`} style={{ width: col.width }}>
<div className={`w-8 h-3 rounded ${isDarkMode ? 'bg-gray-700' : 'bg-gray-200'} animate-pulse`}></div>
<div className={`w-6 h-3 rounded ${isDarkMode ? 'bg-gray-700' : 'bg-gray-200'}`}></div>
</div>
);
}
}, [isDarkMode, task, isSelected, handleSelectChange, styleClasses]);
}, [isDarkMode, task, isSelected, handleSelectChange, styleClasses, scrollableColumns]);
// Optimized column rendering with better performance
const renderColumn = useCallback((col: { key: string; width: number }, isFixed: boolean, index: number, totalColumns: number) => {
// Use simplified rendering for initial load
if (!shouldRenderFull) {
return renderColumnSimple(col, isFixed, index, totalColumns);
return renderMinimalColumn(col, isFixed, index, totalColumns);
}
// Full rendering logic (existing code)
@@ -996,11 +885,21 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
return null;
}
}, [
shouldRenderFull, renderColumnSimple, isDarkMode, task, isSelected, editTaskName, taskName, adapters, groupId, projectId,
shouldRenderFull, renderMinimalColumn, isDarkMode, task, isSelected, editTaskName, taskName, adapters, groupId, projectId,
attributes, listeners, handleSelectChange, handleTaskNameSave, handleDateChange,
dateValues, styleClasses
]);
// Apply global cursor style when dragging
useDragCursor(isDragging);
// Compute theme class
const themeClass = isDarkMode ? 'dark' : '';
if (isDragging) {
console.log('TaskRow isDragging:', task.id);
}
return (
<div
ref={(node) => {
@@ -1008,8 +907,11 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
rowRef.current = node;
}}
style={dragStyle}
className={`${styleClasses.container} task-row-optimized ${shouldRenderFull ? 'fully-loaded' : 'initial-load'} ${hasBeenFullyLoadedOnce.current ? 'stable-content' : ''}`}
className={`task-row task-row-optimized ${themeClass} ${isSelected ? 'selected' : ''} ${isDragOverlay ? 'drag-overlay' : ''} ${isDragging ? 'is-dragging' : ''}`}
data-dnd-draggable="true"
data-dnd-dragging={isDragging ? 'true' : 'false'}
data-task-id={task.id}
data-group-id={groupId}
>
<div className="flex h-10 max-h-10 overflow-visible relative">
{/* Fixed Columns */}
@@ -1020,7 +922,11 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
width: fixedColumns.reduce((sum, col) => sum + col.width, 0),
}}
>
{fixedColumns.map((col, index) => renderColumn(col, true, index, fixedColumns.length))}
{fixedColumns.map((col, index) =>
shouldRenderMinimal
? renderMinimalColumn(col, true, index, fixedColumns.length)
: renderColumn(col, true, index, fixedColumns.length)
)}
</div>
)}
@@ -1033,7 +939,11 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
minWidth: scrollableColumns.reduce((sum, col) => sum + col.width, 0)
}}
>
{scrollableColumns.map((col, index) => renderColumn(col, false, index, scrollableColumns.length))}
{scrollableColumns.map((col, index) =>
shouldRenderMinimal
? renderMinimalColumn(col, false, index, scrollableColumns.length)
: renderColumn(col, false, index, scrollableColumns.length)
)}
</div>
)}
</div>
@@ -1054,7 +964,7 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
// Fix border logic for add subtask row: fixed columns should have right border if scrollable columns exist
const isActuallyLast = index === fixedColumns.length - 1 && (!scrollableColumns || scrollableColumns.length === 0);
const borderClasses = `${isActuallyLast ? '' : 'border-r'} border-b ${isDarkMode ? 'border-gray-600' : 'border-gray-300'}`;
if (col.key === 'task') {
return (
<div
@@ -1123,7 +1033,7 @@ const TaskRow: React.FC<TaskRowProps> = React.memo(({
{scrollableColumns.map((col, index) => {
const isLast = index === scrollableColumns.length - 1;
const borderClasses = `${isLast ? '' : 'border-r'} border-b ${isDarkMode ? 'border-gray-600' : 'border-gray-300'}`;
return (
<div
key={col.key}

175
worklenz-frontend/src/components/task-management/virtualized-task-list.tsx
View File

@@ -21,6 +21,7 @@ interface VirtualizedTaskListProps {
onToggleSubtasks: (taskId: string) => void;
height: number;
width: number;
tasksById: Record<string, Task>;
}
const VirtualizedTaskList: React.FC<VirtualizedTaskListProps> = React.memo(({
@@ -31,9 +32,9 @@ const VirtualizedTaskList: React.FC<VirtualizedTaskListProps> = React.memo(({
onSelectTask,
onToggleSubtasks,
height,
width
width,
tasksById
}) => {
const allTasks = useSelector(taskManagementSelectors.selectAll);
const { t } = useTranslation('task-management');
// Get theme from Redux store
@@ -42,8 +43,8 @@ const VirtualizedTaskList: React.FC<VirtualizedTaskListProps> = React.memo(({
// Get field visibility from taskListFields slice
const taskListFields = useSelector((state: RootState) => state.taskManagementFields) as TaskListField[];
// PERFORMANCE OPTIMIZATION: Reduce virtualization threshold for better performance
const VIRTUALIZATION_THRESHOLD = 20; // Reduced from 100 to 20 - virtualize even smaller lists
// PERFORMANCE OPTIMIZATION: Aggressive virtualization for large lists
const VIRTUALIZATION_THRESHOLD = 5; // Reduced from 10 to 5 - virtualize everything
const TASK_ROW_HEIGHT = 40;
const HEADER_HEIGHT = 40;
const COLUMN_HEADER_HEIGHT = 40;
@@ -121,14 +122,18 @@ const VirtualizedTaskList: React.FC<VirtualizedTaskListProps> = React.memo(({
);
}
// Get tasks for this group using memoization for performance
// PERFORMANCE OPTIMIZATION: Get tasks for this group using direct lookup (no mapping/filtering)
const groupTasks = useMemo(() => {
const tasks = group.taskIds
.map((taskId: string) => allTasks.find((task: Task) => task.id === taskId))
.filter((task: Task | undefined): task is Task => task !== undefined);
// PERFORMANCE OPTIMIZATION: Use for loop instead of map for better performance
const tasks: Task[] = [];
for (let i = 0; i < group.taskIds.length; i++) {
const task = tasksById[group.taskIds[i]];
if (task) {
tasks.push(task);
}
}
return tasks;
}, [group.taskIds, allTasks]);
}, [group.taskIds, tasksById]);
// PERFORMANCE OPTIMIZATION: Only calculate selection state when needed
const selectionState = useMemo(() => {
@@ -136,36 +141,56 @@ const VirtualizedTaskList: React.FC<VirtualizedTaskListProps> = React.memo(({
return { isAllSelected: false, isIndeterminate: false };
}
const selectedTasksInGroup = groupTasks.filter((task: Task) => selectedTaskIds.includes(task.id));
const isAllSelected = selectedTasksInGroup.length === groupTasks.length;
const isIndeterminate = selectedTasksInGroup.length > 0 && selectedTasksInGroup.length < groupTasks.length;
// PERFORMANCE OPTIMIZATION: Use for loop instead of filter for better performance
let selectedCount = 0;
for (let i = 0; i < groupTasks.length; i++) {
if (selectedTaskIds.includes(groupTasks[i].id)) {
selectedCount++;
}
}
const isAllSelected = selectedCount === groupTasks.length;
const isIndeterminate = selectedCount > 0 && selectedCount < groupTasks.length;
return { isAllSelected, isIndeterminate };
}, [groupTasks, selectedTaskIds]);
// Handle select all tasks in group - optimized with useCallback
const handleSelectAllInGroup = useCallback((checked: boolean) => {
// PERFORMANCE OPTIMIZATION: Batch selection updates
const tasksToUpdate: Array<{ taskId: string; selected: boolean }> = [];
if (checked) {
// Select all tasks in the group
groupTasks.forEach((task: Task) => {
for (let i = 0; i < groupTasks.length; i++) {
const task = groupTasks[i];
if (!selectedTaskIds.includes(task.id)) {
onSelectTask(task.id, true);
tasksToUpdate.push({ taskId: task.id, selected: true });
}
});
}
} else {
// Deselect all tasks in the group
groupTasks.forEach((task: Task) => {
for (let i = 0; i < groupTasks.length; i++) {
const task = groupTasks[i];
if (selectedTaskIds.includes(task.id)) {
onSelectTask(task.id, false);
tasksToUpdate.push({ taskId: task.id, selected: false });
}
});
}
}
// Batch update all selections
tasksToUpdate.forEach(({ taskId, selected }) => {
onSelectTask(taskId, selected);
});
}, [groupTasks, selectedTaskIds, onSelectTask]);
// Calculate dynamic height for the group
// PERFORMANCE OPTIMIZATION: Simplified height calculation
const taskRowsHeight = groupTasks.length * TASK_ROW_HEIGHT;
const groupHeight = HEADER_HEIGHT + COLUMN_HEADER_HEIGHT + taskRowsHeight + ADD_TASK_ROW_HEIGHT;
// PERFORMANCE OPTIMIZATION: Limit visible columns for large lists
const maxVisibleColumns = groupTasks.length > 50 ? 6 : 12; // Further reduce columns for large lists
// Define all possible columns
const allFixedColumns = [
{ key: 'drag', label: '', width: 40, alwaysVisible: true },
@@ -210,7 +235,7 @@ const VirtualizedTaskList: React.FC<VirtualizedTaskListProps> = React.memo(({
}, [taskListFields, allFixedColumns]);
const scrollableColumns = useMemo(() => {
return allScrollableColumns.filter(col => {
const filtered = allScrollableColumns.filter(col => {
// For scrollable columns, check field visibility
if (col.fieldKey) {
const field = taskListFields.find(f => f.key === col.fieldKey);
@@ -219,21 +244,31 @@ const VirtualizedTaskList: React.FC<VirtualizedTaskListProps> = React.memo(({
return false;
});
}, [taskListFields, allScrollableColumns]);
// PERFORMANCE OPTIMIZATION: Limit columns for large lists
return filtered.slice(0, maxVisibleColumns);
}, [taskListFields, allScrollableColumns, maxVisibleColumns]);
const fixedWidth = fixedColumns.reduce((sum, col) => sum + col.width, 0);
const scrollableWidth = scrollableColumns.reduce((sum, col) => sum + col.width, 0);
const totalTableWidth = fixedWidth + scrollableWidth;
// PERFORMANCE OPTIMIZATION: Increase overscanCount for better perceived performance
// PERFORMANCE OPTIMIZATION: Optimize overscan for large lists
const shouldVirtualize = groupTasks.length > VIRTUALIZATION_THRESHOLD;
const overscanCount = shouldVirtualize ? Math.min(10, Math.ceil(groupTasks.length * 0.1)) : 0; // Dynamic overscan
const overscanCount = useMemo(() => {
if (groupTasks.length <= 10) return 2;
if (groupTasks.length <= 50) return 3;
return 5; // Reduced from 10 for better performance
}, [groupTasks.length]);
// PERFORMANCE OPTIMIZATION: Memoize row renderer with better dependency management
const Row = useCallback(({ index, style }: { index: number; style: React.CSSProperties }) => {
const task: Task | undefined = groupTasks[index];
if (!task) return null;
// PERFORMANCE OPTIMIZATION: Pre-calculate selection state
const isSelected = selectedTaskIds.includes(task.id);
return (
<div
className="task-row-container"
@@ -248,7 +283,7 @@ const VirtualizedTaskList: React.FC<VirtualizedTaskListProps> = React.memo(({
projectId={projectId}
groupId={group.id}
currentGrouping={currentGrouping}
isSelected={selectedTaskIds.includes(task.id)}
isSelected={isSelected}
index={index}
onSelect={onSelectTask}
onToggleSubtasks={onToggleSubtasks}
@@ -262,23 +297,25 @@ const VirtualizedTaskList: React.FC<VirtualizedTaskListProps> = React.memo(({
const scrollContainerRef = useRef<HTMLDivElement>(null);
const headerScrollRef = useRef<HTMLDivElement>(null);
// PERFORMANCE OPTIMIZATION: Throttled scroll handler
const handleScroll = useCallback(() => {
if (headerScrollRef.current && scrollContainerRef.current) {
headerScrollRef.current.scrollLeft = scrollContainerRef.current.scrollLeft;
}
}, []);
// Synchronize header scroll with body scroll
useEffect(() => {
const handleScroll = () => {
if (headerScrollRef.current && scrollContainerRef.current) {
headerScrollRef.current.scrollLeft = scrollContainerRef.current.scrollLeft;
}
};
const scrollDiv = scrollContainerRef.current;
if (scrollDiv) {
scrollDiv.addEventListener('scroll', handleScroll);
scrollDiv.addEventListener('scroll', handleScroll, { passive: true });
}
return () => {
if (scrollDiv) {
scrollDiv.removeEventListener('scroll', handleScroll);
}
};
}, []);
}, [handleScroll]);
return (
<div className="virtualized-task-list" style={{ height: groupHeight }}>
@@ -363,52 +400,50 @@ const VirtualizedTaskList: React.FC<VirtualizedTaskListProps> = React.memo(({
width={width}
itemCount={groupTasks.length}
itemSize={TASK_ROW_HEIGHT}
overscanCount={overscanCount} // Dynamic overscan
overscanCount={overscanCount}
className="react-window-list"
style={{ minWidth: totalTableWidth }}
// PERFORMANCE OPTIMIZATION: Add performance-focused props
useIsScrolling={true}
itemData={{
groupTasks,
group,
projectId,
currentGrouping,
selectedTaskIds,
onSelectTask,
onToggleSubtasks,
fixedColumns,
scrollableColumns
}}
// PERFORMANCE OPTIMIZATION: Remove all expensive props for maximum performance
useIsScrolling={false}
itemData={undefined}
// Disable all animations and transitions
onItemsRendered={() => {}}
onScroll={() => {}}
>
{Row}
</List>
) : (
// PERFORMANCE OPTIMIZATION: Use React.Fragment to reduce DOM nodes
<React.Fragment>
{groupTasks.map((task: Task, index: number) => (
<div
key={task.id}
className="task-row-container"
style={{
height: TASK_ROW_HEIGHT,
'--group-color': group.color || '#f0f0f0',
contain: 'layout style', // CSS containment
} as React.CSSProperties}
>
<TaskRow
task={task}
projectId={projectId}
groupId={group.id}
currentGrouping={currentGrouping}
isSelected={selectedTaskIds.includes(task.id)}
index={index}
onSelect={onSelectTask}
onToggleSubtasks={onToggleSubtasks}
fixedColumns={fixedColumns}
scrollableColumns={scrollableColumns}
/>
</div>
))}
{groupTasks.map((task: Task, index: number) => {
// PERFORMANCE OPTIMIZATION: Pre-calculate selection state
const isSelected = selectedTaskIds.includes(task.id);
return (
<div
key={task.id}
className="task-row-container"
style={{
height: TASK_ROW_HEIGHT,
'--group-color': group.color || '#f0f0f0',
contain: 'layout style', // CSS containment
} as React.CSSProperties}
>
<TaskRow
task={task}
projectId={projectId}
groupId={group.id}
currentGrouping={currentGrouping}
isSelected={isSelected}
index={index}
onSelect={onSelectTask}
onToggleSubtasks={onToggleSubtasks}
fixedColumns={fixedColumns}
scrollableColumns={scrollableColumns}
/>
</div>
);
})}
</React.Fragment>
)}
</SortableContext>