From 382283d0ce8d1b3c102c11136c71852d25179921 Mon Sep 17 00:00:00 2001 From: shancds Date: Wed, 2 Jul 2025 11:20:56 +0530 Subject: [PATCH 1/3] fix(enhanced-kanban): update subtask placeholder text for clarity --- .../enhanced-kanban/EnhancedKanbanCreateSubtaskCard.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanCreateSubtaskCard.tsx b/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanCreateSubtaskCard.tsx index 5cd0dabc..5e1aa377 100644 --- a/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanCreateSubtaskCard.tsx +++ b/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanCreateSubtaskCard.tsx @@ -161,7 +161,7 @@ const EnhancedKanbanCreateSubtaskCard = ({ onKeyUp={e => e.stopPropagation()} onKeyPress={e => e.stopPropagation()} onBlur={handleInputBlur} - placeholder={t('kanbanBoard.addSubTaskPlaceholder')} + placeholder={t('newSubtaskNamePlaceholder')} className={`enhanced-kanban-create-subtask-input ${themeMode === 'dark' ? 'dark' : ''}`} disabled={creatingTask} autoFocus From 71e1d58ec66ccbf4612e9010d3be3c873b0157b7 Mon Sep 17 00:00:00 2001 From: shancds Date: Wed, 2 Jul 2025 11:41:43 +0530 Subject: [PATCH 2/3] refactor(enhanced-kanban): simplify task creation event handling - Updated the event handler in EnhancedKanbanCreateTaskCard to clarify that the form reset is separate from the global task addition to Redux, improving code readability and maintainability. --- .../components/enhanced-kanban/EnhancedKanbanCreateTaskCard.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanCreateTaskCard.tsx b/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanCreateTaskCard.tsx index dbb17262..04c02670 100644 --- a/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanCreateTaskCard.tsx +++ b/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanCreateTaskCard.tsx @@ -89,7 +89,7 @@ const EnhancedKanbanCreateTaskCard: React.FC // Real-time socket event handler const eventHandler = (task: IProjectTask) => { - dispatch(addTaskToGroup({ sectionId, task: { ...task, id: task.id || nanoid(), name: task.name || newTaskName.trim() } })); + // Only reset the form - the global handler will add the task to Redux socket?.off(SocketEvents.QUICK_TASK.toString(), eventHandler); resetForNextTask(); }; From d56eaa9f0208b11b23d9c2dc33b1310e88203f76 Mon Sep 17 00:00:00 2001 From: shancds Date: Wed, 2 Jul 2025 12:05:54 +0530 Subject: [PATCH 3/3] fix(enhanced-kanban): prevent unnecessary state updates on blur event --- .../src/components/enhanced-kanban/EnhancedKanbanGroup.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanGroup.tsx b/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanGroup.tsx index 5d7aa3f2..2119719f 100644 --- a/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanGroup.tsx +++ b/worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanGroup.tsx @@ -194,10 +194,11 @@ const EnhancedKanbanGroup: React.FC = React.memo(({ }; const handleBlur = async () => { + setIsEditable(false); + if (name === editName) return; if (name === 'Untitled section') { dispatch(fetchEnhancedKanbanGroups(projectId ?? '')); } - setIsEditable(false); if (!projectId || !group.id) return;