bo/worklenz
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(enhanced-kanban): improve code readability and loading state visuals

Browse Source 
- Refactored conditional statements for better clarity and consistency.
- Enhanced loading state visuals by replacing static text with a dynamic skeleton loader, improving user experience during data fetching.
This commit is contained in:
shancds
2025-07-11 15:07:33 +05:30
parent 0efcbf448b
commit 93b67fba07
1 changed files with 18 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

33
worklenz-frontend/src/components/enhanced-kanban/EnhancedKanbanBoardNativeDnD/EnhancedKanbanBoardNativeDnD.tsx
View File

@@ -127,9 +127,9 @@ const EnhancedKanbanBoardNativeDnD: React.FC<{ projectId: string }> = ({ project
if (draggedTaskId) { if (draggedTaskId) {
setHoveredGroupId(groupId); setHoveredGroupId(groupId);
} }
if(taskIdx === null) { if (taskIdx === null) {
setHoveredTaskIdx(0); setHoveredTaskIdx(0);
}else{ } else {
setHoveredTaskIdx(taskIdx); setHoveredTaskIdx(taskIdx);
}; };
}; };
@@ -137,16 +137,16 @@ const EnhancedKanbanBoardNativeDnD: React.FC<{ projectId: string }> = ({ project
if (dragType !== 'task') return; if (dragType !== 'task') return;
e.preventDefault(); e.preventDefault();
if (!draggedTaskId || !draggedTaskGroupId || hoveredGroupId === null || hoveredTaskIdx === null) return; if (!draggedTaskId || !draggedTaskGroupId || hoveredGroupId === null || hoveredTaskIdx === null) return;
// Calculate new order and dispatch // Calculate new order and dispatch
const sourceGroup = taskGroups.find(g => g.id === draggedTaskGroupId); const sourceGroup = taskGroups.find(g => g.id === draggedTaskGroupId);
const targetGroup = taskGroups.find(g => g.id === targetGroupId); const targetGroup = taskGroups.find(g => g.id === targetGroupId);
if (!sourceGroup || !targetGroup) return; if (!sourceGroup || !targetGroup) return;
const taskIdx = sourceGroup.tasks.findIndex(t => t.id === draggedTaskId); const taskIdx = sourceGroup.tasks.findIndex(t => t.id === draggedTaskId);
if (taskIdx === -1) return; if (taskIdx === -1) return;
const movedTask = sourceGroup.tasks[taskIdx]; const movedTask = sourceGroup.tasks[taskIdx];
if (groupBy === 'status' && movedTask.id) { if (groupBy === 'status' && movedTask.id) {
if (sourceGroup.id !== targetGroup.id) { if (sourceGroup.id !== targetGroup.id) {
@@ -161,23 +161,23 @@ const EnhancedKanbanBoardNativeDnD: React.FC<{ projectId: string }> = ({ project
} }
} }
let insertIdx = hoveredTaskIdx; let insertIdx = hoveredTaskIdx;
// Handle same group reordering // Handle same group reordering
if (sourceGroup.id === targetGroup.id) { if (sourceGroup.id === targetGroup.id) {
// Create a single updated array for the same group // Create a single updated array for the same group
const updatedTasks = [...sourceGroup.tasks]; const updatedTasks = [...sourceGroup.tasks];
updatedTasks.splice(taskIdx, 1); // Remove from original position updatedTasks.splice(taskIdx, 1); // Remove from original position
// Adjust insert index if moving forward in the same array // Adjust insert index if moving forward in the same array
if (taskIdx < insertIdx) { if (taskIdx < insertIdx) {
insertIdx--; insertIdx--;
} }
if (insertIdx < 0) insertIdx = 0; if (insertIdx < 0) insertIdx = 0;
if (insertIdx > updatedTasks.length) insertIdx = updatedTasks.length; if (insertIdx > updatedTasks.length) insertIdx = updatedTasks.length;
updatedTasks.splice(insertIdx, 0, movedTask); // Insert at new position updatedTasks.splice(insertIdx, 0, movedTask); // Insert at new position
dispatch(reorderTasks({ dispatch(reorderTasks({
activeGroupId: sourceGroup.id, activeGroupId: sourceGroup.id,
overGroupId: targetGroup.id, overGroupId: targetGroup.id,
@@ -200,12 +200,12 @@ const EnhancedKanbanBoardNativeDnD: React.FC<{ projectId: string }> = ({ project
// Handle cross-group reordering // Handle cross-group reordering
const updatedSourceTasks = [...sourceGroup.tasks]; const updatedSourceTasks = [...sourceGroup.tasks];
updatedSourceTasks.splice(taskIdx, 1); updatedSourceTasks.splice(taskIdx, 1);
const updatedTargetTasks = [...targetGroup.tasks]; const updatedTargetTasks = [...targetGroup.tasks];
if (insertIdx < 0) insertIdx = 0; if (insertIdx < 0) insertIdx = 0;
if (insertIdx > updatedTargetTasks.length) insertIdx = updatedTargetTasks.length; if (insertIdx > updatedTargetTasks.length) insertIdx = updatedTargetTasks.length;
updatedTargetTasks.splice(insertIdx, 0, movedTask); updatedTargetTasks.splice(insertIdx, 0, movedTask);
dispatch(reorderTasks({ dispatch(reorderTasks({
activeGroupId: sourceGroup.id, activeGroupId: sourceGroup.id,
overGroupId: targetGroup.id, overGroupId: targetGroup.id,
@@ -317,8 +317,11 @@ const EnhancedKanbanBoardNativeDnD: React.FC<{ projectId: string }> = ({ project
<div className="enhanced-kanban-board"> <div className="enhanced-kanban-board">
{loadingGroups ? ( {loadingGroups ? (
<Card> <Card>
<div className="flex justify-center items-center py-8"> <div className="flex flex-row gap-2 h-[600px] py-2">
<Skeleton active /> <div className="rounded bg-gray-200 dark:bg-gray-700 animate-pulse w-1/4" style={{ height: '60%' }} />
<div className="rounded bg-gray-200 dark:bg-gray-700 animate-pulse w-1/4" style={{ height: '100%' }} />
<div className="rounded bg-gray-200 dark:bg-gray-700 animate-pulse w-1/4" style={{ height: '80%' }} />
<div className="rounded bg-gray-200 dark:bg-gray-700 animate-pulse w-1/4" style={{ height: '40%' }} />
</div> </div>
</Card> </Card>
) : taskGroups.length === 0 ? ( ) : taskGroups.length === 0 ? (