Merge pull request #145 from shancds/feature/project-finance

Feature/project finance
This commit is contained in:
Chamika J
2025-05-28 13:02:34 +05:30
committed by GitHub
5 changed files with 180 additions and 149 deletions

View File

@@ -35,7 +35,8 @@
"ratecardsPluralText": "Rate Card Templates", "ratecardsPluralText": "Rate Card Templates",
"deleteConfirm": "Are you sure ?", "deleteConfirm": "Are you sure ?",
"yes": "Yes", "yes": "Yes",
"no": "No" "no": "No",
"alreadyImportedRateCardMessage": "A rate card has already been imported. Clear all imported rate cards to add a new one."
} }

View File

@@ -23,7 +23,8 @@ const RateCardAssigneeSelector = ({
onChange, onChange,
selectedMemberIds = [], selectedMemberIds = [],
memberlist = [], memberlist = [],
}: RateCardAssigneeSelectorProps) => { assignedMembers = [], // New prop: List of all assigned member IDs across all job titles
}: RateCardAssigneeSelectorProps & { assignedMembers: string[] }) => {
const membersInputRef = useRef<InputRef>(null); const membersInputRef = useRef<InputRef>(null);
const [searchQuery, setSearchQuery] = useState(''); const [searchQuery, setSearchQuery] = useState('');
const [members, setMembers] = useState<IProjectMemberViewModel[]>(memberlist); const [members, setMembers] = useState<IProjectMemberViewModel[]>(memberlist);
@@ -46,7 +47,12 @@ const RateCardAssigneeSelector = ({
/> />
<List style={{ padding: 0, maxHeight: 200, overflow: 'auto' }}> <List style={{ padding: 0, maxHeight: 200, overflow: 'auto' }}>
{filteredMembers.length ? ( {filteredMembers.length ? (
filteredMembers.map((member) => ( filteredMembers.map((member) => {
const isAssignedToAnotherJobTitle =
assignedMembers.includes(member.id || '') &&
!selectedMemberIds.includes(member.id || ''); // Check if the member is assigned elsewhere
return (
<List.Item <List.Item
key={member.id} key={member.id}
style={{ style={{
@@ -55,14 +61,14 @@ const RateCardAssigneeSelector = ({
alignItems: 'center', alignItems: 'center',
padding: '4px 8px', padding: '4px 8px',
border: 'none', border: 'none',
opacity: member.pending_invitation ? 0.5 : 1, opacity: member.pending_invitation || isAssignedToAnotherJobTitle ? 0.5 : 1,
justifyContent: 'flex-start', justifyContent: 'flex-start',
textAlign: 'left', textAlign: 'left',
}} }}
> >
<Checkbox <Checkbox
checked={selectedMemberIds.includes(member.id || '')} checked={selectedMemberIds.includes(member.id || '')}
disabled={member.pending_invitation} disabled={member.pending_invitation || isAssignedToAnotherJobTitle}
onChange={() => onChange?.(member.id || '')} onChange={() => onChange?.(member.id || '')}
/> />
<SingleAvatar <SingleAvatar
@@ -72,7 +78,8 @@ const RateCardAssigneeSelector = ({
/> />
<span>{member.name}</span> <span>{member.name}</span>
</List.Item> </List.Item>
)) );
})
) : ( ) : (
<Empty description="No members found" /> <Empty description="No members found" />
)} )}

View File

@@ -1,4 +1,4 @@
import { Drawer, Typography, Button, Table, Menu, Flex, Spin } from 'antd'; import { Drawer, Typography, Button, Table, Menu, Flex, Spin, Alert } from 'antd';
import React, { useEffect, useState } from 'react'; import React, { useEffect, useState } from 'react';
import { useTranslation } from 'react-i18next'; import { useTranslation } from 'react-i18next';
import { useAppSelector } from '../../../hooks/useAppSelector'; import { useAppSelector } from '../../../hooks/useAppSelector';
@@ -84,10 +84,21 @@ const ImportRatecardsDrawer: React.FC = () => {
</Typography.Text> </Typography.Text>
} }
footer={ footer={
<div style={{ textAlign: 'right' }}>
{/* Alert message */}
{rolesRedux.length !== 0 ? (
<div style={{ textAlign: 'right' }}>
<Alert
message={t('alreadyImportedRateCardMessage') || 'A rate card has already been imported. Clear all imported rate cards to add a new one.'}
type="warning"
showIcon
style={{ marginBottom: 16 }}
/>
</div>
) : (
<div style={{ textAlign: 'right' }}> <div style={{ textAlign: 'right' }}>
<Button <Button
type="primary" type="primary"
disabled={rolesRedux.length !== 0}
onClick={() => { onClick={() => {
if (!projectId) { if (!projectId) {
// Handle missing project id (show error, etc.) // Handle missing project id (show error, etc.)
@@ -112,6 +123,8 @@ const ImportRatecardsDrawer: React.FC = () => {
{t('import')} {t('import')}
</Button> </Button>
</div> </div>
)}
</div>
} }
open={isDrawerOpen} open={isDrawerOpen}
onClose={() => dispatch(toggleImportRatecardsDrawer())} onClose={() => dispatch(toggleImportRatecardsDrawer())}

View File

@@ -307,8 +307,8 @@ const RatecardDrawer = ({
}, },
]; ];
const handleDrawerClose = () => { const handleDrawerClose = async() => {
if (!name || name.trim() === '' || name === 'Untitled Rate Card') { if (!name || name.trim() === '') {
messageApi.open({ messageApi.open({
type: 'warning', type: 'warning',
content: t('ratecardNameRequired') || 'Rate card name is required.', content: t('ratecardNameRequired') || 'Rate card name is required.',
@@ -316,7 +316,12 @@ const RatecardDrawer = ({
return; return;
} else if (hasChanges) { } else if (hasChanges) {
setShowUnsavedAlert(true); setShowUnsavedAlert(true);
} else { }
else if (name === 'Untitled Rate Card' && roles.length === 0){
await dispatch(deleteRateCard(ratecardId));
dispatch(toggleRatecardDrawer());
}
else {
dispatch(toggleRatecardDrawer()); dispatch(toggleRatecardDrawer());
} }
}; };

View File

@@ -191,6 +191,10 @@ const RatecardTable: React.FC = () => {
} }
}; };
const assignedMembers = roles
.flatMap((role) => role.members || [])
.filter((memberId, index, self) => self.indexOf(memberId) === index);
// Columns // Columns
const columns: TableProps<JobRoleType>['columns'] = [ const columns: TableProps<JobRoleType>['columns'] = [
{ {
@@ -267,6 +271,7 @@ const RatecardTable: React.FC = () => {
selectedMemberIds={memberscol || []} selectedMemberIds={memberscol || []}
onChange={(memberId) => handleMemberChange(memberId, index, record)} onChange={(memberId) => handleMemberChange(memberId, index, record)}
memberlist={members} memberlist={members}
assignedMembers={assignedMembers} // Pass assigned members here
/> />
</div> </div>
</div> </div>