bo/worklenz
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(task-status): enhance task status change handling to reset manual progress

Browse Source 
- Added logic to reset manual_progress to FALSE when a task transitions from "done" to "todo" or "doing", allowing for accurate progress recalculation based on subtasks.
- Improved logging for task status changes to provide better insights into task management actions.
- Ensured parent task progress updates are triggered appropriately for subtasks during status changes.
This commit is contained in:
shancds
2025-07-01 10:18:56 +05:30
parent c048085c8a
commit e5ff036d81
1 changed files with 22 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
worklenz-backend/src/socket.io/commands/on-task-status-change.ts
View File

@@ -58,10 +58,10 @@ export async function on_task_status_change(_io: Server, socket: Socket, data?:
FROM tasks FROM tasks
WHERE id = $1 WHERE id = $1
`, [body.task_id]); `, [body.task_id]);
const currentProgress = progressResult.rows[0]?.progress_value; const currentProgress = progressResult.rows[0]?.progress_value;
const isManualProgress = progressResult.rows[0]?.manual_progress; const isManualProgress = progressResult.rows[0]?.manual_progress;
// Only update if not already 100% // Only update if not already 100%
if (currentProgress !== 100) { if (currentProgress !== 100) {
// Update progress to 100% // Update progress to 100%
@@ -70,9 +70,9 @@ export async function on_task_status_change(_io: Server, socket: Socket, data?:
SET progress_value = 100, manual_progress = TRUE SET progress_value = 100, manual_progress = TRUE
WHERE id = $1 WHERE id = $1
`, [body.task_id]); `, [body.task_id]);
log(`Task ${body.task_id} moved to done status - progress automatically set to 100%`, null); log(`Task ${body.task_id} moved to done status - progress automatically set to 100%`, null);
// Log the progress change to activity logs // Log the progress change to activity logs
await logProgressChange({ await logProgressChange({
task_id: body.task_id, task_id: body.task_id,
@@ -80,7 +80,7 @@ export async function on_task_status_change(_io: Server, socket: Socket, data?:
new_value: "100", new_value: "100",
socket socket
}); });
// If this is a subtask, update parent task progress // If this is a subtask, update parent task progress
if (body.parent_task) { if (body.parent_task) {
setTimeout(() => { setTimeout(() => {
@@ -88,6 +88,23 @@ export async function on_task_status_change(_io: Server, socket: Socket, data?:
}, 100); }, 100);
} }
} }
} else {
// Task is moving from "done" to "todo" or "doing" - reset manual_progress to FALSE
// so progress can be recalculated based on subtasks
await db.query(`
UPDATE tasks
SET manual_progress = FALSE
WHERE id = $1
`, [body.task_id]);
log(`Task ${body.task_id} moved from done status - manual_progress reset to FALSE`, null);
// If this is a subtask, update parent task progress
if (body.parent_task) {
setTimeout(() => {
socket.emit(SocketEvents.GET_TASK_PROGRESS.toString(), body.parent_task);
}, 100);
}
} }
const info = await TasksControllerV2.getTaskCompleteRatio(body.parent_task || body.task_id); const info = await TasksControllerV2.getTaskCompleteRatio(body.parent_task || body.task_id);