bo/worklenz
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(tasks-controller): cap progress calculation at 100% and synchronize complete_ratio

Browse Source 
- Updated progress calculation to ensure it does not exceed 100% when time-based progress is enabled.
- Set complete_ratio to match the calculated progress, improving accuracy in task completion representation.
- Simplified comments for clarity regarding progress defaults and calculations.
This commit is contained in:
chamikaJ
2025-06-09 13:05:34 +05:30
parent 6e188899ed
commit e3e1b2dc14
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
worklenz-backend/src/controllers/tasks-controller-base.ts
View File

@@ -52,15 +52,17 @@ export default class TasksControllerBase extends WorklenzControllerBase {
}
// For tasks with no subtasks and no manual progress
else {
// Only calculate time-based progress if time-based calculation is enabled for the project
// Only calculate progress based on time if time-based progress is enabled for the project
if (task.project_use_time_progress && task.total_minutes_spent && task.total_minutes) {
task.progress = ~~(task.total_minutes_spent / task.total_minutes * 100);
task.complete_ratio = task.progress;
// Cap the progress at 100% to prevent showing more than 100% progress
task.progress = Math.min(~~(task.total_minutes_spent / task.total_minutes * 100), 100);
} else {
// Default to 0% progress for incomplete tasks when time-based calculation is not enabled
// Default to 0% progress when time-based calculation is not enabled
task.progress = 0;
task.complete_ratio = 0;
}
// Set complete_ratio to match progress
task.complete_ratio = task.progress;
}
// Ensure numeric values